Deleting files with search dialog open may delete wrong file

[grumps]

I can not reliably reproduce this but sometimes there seems to be an issue with what item selection is used for performing an operation when the search dialog is open in the background: either the selection made in the search results or the selection made in the active tab.

Scenario that made this happen a couple of times while trying to reproduce:

- Start FC
- open search dialog (alt-f7)
- perform a search that produces some results
- ctrl-click to select a couple of items in the search results
- focus main window
- select some items in the main window tab
- shift-delete the selection in the main window

Now a few things can happen, i can not reliably reproduce one or another:

1) popup appears to confirm deletion of the selection made in the main window --> this is what i expect
2) search dialog is moved to the top and a popup appears to confirm deletion of the selection still present in the search results --> counter intuitive, but at least a lot happens on the screen which alerts me something weird is going on
3) search dialog stays in background and a popup appears to confirm deletion of the selection still present in the search dialog --> UGH! this made me loose files because i didn't read the delete confirmation dialog closely...

Arguably actually losing files is my fault but this can't be the intended behavior.

I can reproduce scenario 2 by doing this a couple of times restarting FC between every few attempts to reproduce. I try to vary the mouseclicks made after switching to the main window (click titlebar to focus it / click current tab-thingy to focus it / click default selected row entry to focus it / etc), while this does not guarantee certain behavior i have the feeling this does have something to do with it.

Environment:
Win7x64
FC XE build 570 public preview

[Karol]

I can't reproduce it.

- focus main window

How do you change the focus?

[grumps]

I did some more testing and managed to narrow it down. It still doesn't happen every single time but i can reliably reproduce it by doing the following (turns out shift-delete is not required, delete also works, makes testing safer ):

- start freecommander
- tabs from last time are auto loaded, one of them has focus with no items selected
- press alt-f7
- enter * in search box, click find
- search results are presented, top entry is automatically selected
(you should have made it so that you can still see the main window in the background with the active tab not obscured by the find dialog)
- click a single file in the active tab in the main window which is still in the background at this point, main window is brought to front and the single file is selected
- enter delete

now either this will happen:
- the search window jumps to front and a dialog is shown to confirm deletion of the top entry
- pressing ESC or clicking No to dismiss the dialog removes the top entry from the search results
- clicking find again luckily brings it back so it wasn't deleted (clicking yes does delete it of course), but it should have deleted the selection in the main window in the first place so this is actually a new issue i didnt notice before

or this:
- a confirmation dialog is shown to delete the file selected in the main window, meaning everything went ok
now proceed like this to reproduce it anyway:
- dismiss the delete dialog with ESC or No
- click title bar of search window which is now in the background
- click find, the same results are shown and again the top entry is selected
- click a single file in the active tab in the main window which is now in the background
- press delete, now it will proceed like the faulty scenario above, If not, keep repeating this scenario till it does, for me it takes 2 tries maximum.

[Marek]

@grumps
Thanks for the bug report, I can reproduce it.