597 - regression: favorite toolbar position not kept

[inglorious]

not again! fav. toolbar position is not kept. after a restart the toolbars "move around" although "locked".
please fix this nasty bug once for good!! this bug is really annoying!

[Marek]

The toolbar position works properly for me.
Please try to build an example with the problem and send me all config files.

[inglorious]

as you asked for it here's the video proof:


I've pmed you FreeCommander.ini, FreeCommander.fav.xml & FreeCommander.fav.ini
btw, why do you need/write 2 fav. files anyway?

[Marek]

I've pmed you FreeCommander.ini, FreeCommander.fav.xml & FreeCommander.fav.ini

Unfortunatelly it works for me properly with your files (Win7/64).

why do you need/write 2 fav. files anyway?

"Favorite tools" and "Favorite folders".

[BGM]

I've had this problem, too, for ages, and have been complaining about it here: http://forum.freecommander.com/viewtopic.php?f=7&t=4089

I sure would like to see this one go away!

[inglorious]

I cannot believe this bug ain't reproducible. I'll send you the complete folder from this video:

please fix it once for good!

update: just in case, my screen resolution is set to 1280x1024, FC window is not maximized, use sizer.exe if needed

[BGM]

Yes, I can reproduce this time after time. In fact, it happens every single time without fail. I have to brace myself !

I don't have any problem, however when I close FC and reopen it - the toolbars are all okay - its just when I click the OK button after I edit the favourite toolbars.

[Marek]

I cannot believe this bug ain't reproducible. I'll send you the complete folder from this video

It is not reproducable for me. Your files works properly on my PC and in VM.

[BGM]

Marek, would you like to try mine?

[inglorious]

Marek, would you like to try mine?

yeeees please, this issue bugs me so much I even sticked to build 596 on a machine as it surprisingly works there most of the time.

a possible solution/implementation could be to "snap" toolbars to the main window or to other toolbars.

in case you still not able to repro, I am willing to help tracing this bug down in ollydgb or ms debugger, pm me a debug version and instructions.

[Marek]

Marek, would you like to try mine?

Yes, I can reproduce it. It is fixed for the release 598.

[inglorious]

It is fixed for the release 598.

no it is not! issue persists!

[BGM]

Same here! It isn't fixed yet. The toolbar positions still get scrambled. Marek, can I send you my ini files?

[inglorious]

at last! I figured out what causes the issue!

to reproduce, create three favorite toolbars
one fav. toolbar has 8 items, the second 7 and the third 2 items

check:
Integrate favorite toolbars with action toolbars
select
define action toolbars/general Options/many toolbars
unselect: Show menu as toolbar


now add an item to the second toolbar, to get 8 items in total, restart FC
-> BUG, see video:


I pm you the complete FC folder (bad_ = 8 items = bug) and (ok_ = 7 items) to verify & finally fix this %§$(%§ bug!
BGM, you owe me a coffee!

[BGM]

Do you mean to say that adding more than 7 items to a toolbar is what causes the scramble?

@inglorious, I'd love to buy you a coffee, actually. Do you live close by?